Change the TURNPool API types safely - edit types and markers, regenerate, update webhooks, tests and docs. Use whenever a field is added, removed or re-marked in api/v1alpha1.
The English summary is being prepared. Showing the original description.
Run score Not tested
See how to installReview the instructions the agent will receive before you install.
Work in this order. Each step catches a different class of mistake.
api/v1alpha1/turnpool_types.go.
+optional or +required. No floats. Ratios are
portsInUse/portsTotal integers that consumers divide.+listType=map + +listMapKey=<key> (or +listType=atomic with
a one-line reason). Avoid maps.+optional and derived from the spec, never cached
from it. Conditions stay the first status field, set with
meta.SetStatusCondition.+kubebuilder:validation:Enum
marker, and every switch over it (the exhaustive linter fails the
build otherwise). Add the doc comment on the new value, and the
AGENTS.md glossary line for it when the value names a domain concept, in
the same edit.internal/webhook/v1alpha1/turnpool_webhook.go is part of the change, with
the reason in the validation message.make generate manifests api-docs). Never hand-edit
zz_generated.deepcopy.go, config/crd/bases/*, config/rbac/role.yaml or
docs/api.md.internal/webhook/v1alpha1/turnpool_webhook_test.go for defaulting and
each rejection (envtest, table-driven).internal/relay golden files if the rendered coturn config changes; a new
field that reaches the data plane always changes the goldens.test/e2e/ if the field is observable from outside.docs/api.md is generated. docs/architecture.md and
docs/capacity-model.md are not. A new addressing mode also needs an ADR
(add-addressing-mode).make ci. If the change touches the data plane,
make test-e2e.Report which files changed and which command proved the change.
No reviews yet. Tell others what you thought.
No login needed. Share how it worked for you, ask a question, or note where it did not run.
No comments yet. Be the first to write one.
Add a new addressing mode to Turnfleet - implement Planner and Renderer, golden tests, an e2e case and an ADR. Use when a new way of assigning relay addresses or port ranges is needed.
The English summary is being prepared. Showing the original description.
Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to "review since X".
The English summary is being prepared. Showing the original description.
Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary.
The English summary is being prepared. Showing the original description.
Diagnosis loop for hard bugs and performance regressions. Use when the user says "diagnose"/"debug this", or reports something broken/throwing/failing/slow.
The English summary is being prepared. Showing the original description.
Build and sharpen a project's domain model. Use when discussing codebase terminology, writing or editing a GLOSSARY.md, or recording or editing an ADR.
The English summary is being prepared. Showing the original description.
Debug a failing relay end to end - inspect the kind cluster, relay logs and rendered coturn config, and run turnfleet-probe by hand. Use when a relay never forms, a probe fails, or an e2e case breaks.
The English summary is being prepared. Showing the original description.