Use when writing acceptance criteria for a task - express each as an observable Given/When/Then that QA can execute, including negative cases
The English summary is being prepared. Showing the original description.
Use when reviewing Java or Kotlin server changes on Spring or Quarkus - security config and method security, JPA/JPQL and JdbcTemplate queries, request binding, deserialization, XML parsers, SpEL, templates, Actuator, JNDI and reflection
The English summary is being prepared. Showing the original description.
See how to installReview the instructions the agent will receive before you install.
On the JVM the dangerous code is often configuration: a matcher order, a missing @EnableMethodSecurity, a Jackson typing setting, an Actuator exposure list. Read config and annotation diffs with the same care as handler code.
requestMatchers(...) rules are evaluated in order; a broad permitAll() placed above a narrower hasRole("ADMIN") wins.@PreAuthorize/@Secured/@RolesAllowed do nothing without method security enabled (@EnableMethodSecurity); a new annotated method in a module that never enables it is unprotected.csrf { disable() } / .csrf().disable() while sessions use cookies → CSRF on every state change.// ❌ the admin rule is never reached for /api/admin/**
http.authorizeHttpRequests {
it.requestMatchers("/api/**").permitAll()
it.requestMatchers("/api/admin/**").hasRole("ADMIN")
}
// ✅ most specific first, deny by default
http.authorizeHttpRequests {
it.requestMatchers("/api/admin/**").hasRole("ADMIN")
it.requestMatchers("/api/public/**").permitAll()
it.anyRequest().authenticated()
}
Quarkus: a resource method without @RolesAllowed/@Authenticated where its siblings have one; @PermitAll added; quarkus.http.auth.permission.<name>.policy=permit widened to a broader paths=; quarkus.security.jaxrs.deny-unannotated-endpoints turned off.
// ❌ JPQL injection
em.createQuery("SELECT u FROM User u WHERE u.email = '" + email + "'", User.class);
// ✅
em.createQuery("SELECT u FROM User u WHERE u.email = :email", User.class).setParameter("email", email);
Also: createNativeQuery with concatenation; JdbcTemplate.query("… " + x); @Query built with string concatenation in a custom repository; Spring Data JpaSort.unsafe(userInput) (plain Sort.by validates property names — unsafe does not); Panache find("name = '" + n + "'") instead of find("name", n) or find("name = ?1", n).
// ❌ the JPA entity is the request body: role, ownerId, verified are all client-settable
@PostMapping("/users/{id}") User update(@PathVariable UUID id, @RequestBody User body) { … }
// ✅ a request record with only the editable fields
record UpdateProfile(String displayName, String bio) {}
@ModelAttribute on an entity binds every setter unless @InitBinder restricts setAllowedFields. Returning the entity serialises fields like passwordHash.
ObjectInputStream.readObject on network, cache, cookie or file input without an ObjectInputFilter allowlist.activateDefaultTyping(...) / enableDefaultTyping(), or @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS) on a type bound from requests — the client picks the class.XMLDecoder, XStream without a type allowlist, SnakeYAML < 2.0 new Yaml().load(...), Kryo without registration required, Hessian/Burlap endpoints.Class.forName(userValue) + instantiation; InitialContext.lookup(userValue) (JNDI → remote class loading) — CRITICAL when reachable.// ❌ DTDs and external entities resolved
DocumentBuilder db = DocumentBuilderFactory.newInstance().newDocumentBuilder();
// ✅
DocumentBuilderFactory f = DocumentBuilderFactory.newInstance();
f.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
f.setXIncludeAware(false);
f.setExpandEntityReferences(false);
The same applies to SAXParserFactory, XMLInputFactory (SUPPORT_DTD false), TransformerFactory, SchemaFactory, Unmarshaller built on an unconfigured source.
// ❌ SpEL from input with a full evaluation context → T(java.lang.Runtime).getRuntime().exec(…)
parser.parseExpression(userFilter).getValue(new StandardEvaluationContext(root));
// ✅ no user-authored expressions; if unavoidable, SimpleEvaluationContext (no type references)
parser.parseExpression(userFilter).getValue(SimpleEvaluationContext.forReadOnlyDataBinding().build(), root);
Thymeleaf: a controller returning a view name built from input ("pages/" + page) enables expression preprocessing (__${…}__); th:utext with user content is XSS. FreeMarker templates authored by users with ?new / ?api available.
management.endpoints.web.exposure.include=* (or adding env, heapdump, threaddump, jolokia, loggers) on a port reachable without authentication → secrets in env/heap dumps, HIGH.server.error.include-stacktrace=always / include-message=always in production profiles → information exposure (note unless it leaks secrets).Runtime.exec(String) tokenises without a shell; ProcessBuilder("sh", "-c", cmd) and arrayOf("bash", "-c", …) reintroduce it.Paths.get(base, name).normalize().startsWith(base) ignores symlinks — compare toRealPath() (path-traversal-and-file-handling).java.util.Random / kotlin.random.Random / Math.random() for tokens → SecureRandom.JWT.decode(token) (java-jwt) does not verify; jjwt parser().unsecured() or accepting unsecured JWS; algorithm not pinned.X509TrustManager, HostnameVerifier { _, _ -> true }, NoopHostnameVerifier.setParameter or derived Spring Data queries as SQL injection.Runtime.exec(String) as shell injection.permitAll() or @PermitAll in a diff; csrf disabled in a cookie-session app.+ inside createQuery, createNativeQuery, JdbcTemplate, Panache find(.readObject(, activateDefaultTyping, Id.CLASS, XMLDecoder, InitialContext.lookup.parseExpression( on anything from a request.exposure.include=* outside a dev profile.Spring Security reference · Quarkus security · CWE-89, 285, 470, 502, 611, 863, 915, 917, 1336 · OWASP Top 10:2025
No reviews yet. Tell others what you thought.
No login needed. Share how it worked for you, ask a question, or note where it did not run.
No comments yet. Be the first to write one.
Use when writing acceptance criteria for a task - express each as an observable Given/When/Then that QA can execute, including negative cases
The English summary is being prepared. Showing the original description.
Use when the diff adds or changes an endpoint, resolver, RPC, job or query that takes an object id, a role check, a request binding or a tenant filter - BOLA/IDOR, function-level authorization, mass assignment and tenant scoping
The English summary is being prepared. Showing the original description.
Use on every UI change - semantic HTML, labels for controls, keyboard-navigable dialogs/menus, visible focus, and never color as the only signal
The English summary is being prepared. Showing the original description.
Use when a task changes any screen, form, dialog, menu or control - Lighthouse/axe scan of the changed screens, a keyboard walk, and the thresholds that fail a task
The English summary is being prepared. Showing the original description.
How to work a task returned with review, QA or UAT findings. Use when a task is in need_revision or PR review comments are in your context.
The English summary is being prepared. Showing the original description.
Use when the repository keeps its alerting in code, or a person asks for alerts outside TaskTrooper - PrometheusRule YAML, a Cloud Monitoring alert policy in Terraform, a Datadog monitor, each routed to TaskTrooper's alert ingest URL so it opens an incident here
The English summary is being prepared. Showing the original description.