Definition of Done Skill
DoD checklist enforcement.
Completion Audit: Anti-Bias Clauses
Before checking any item below as DONE, perform a completion audit against the actual current state, not against intent or memory:
- Restate the acceptance criteria as concrete deliverables. Map every numbered requirement, named file, command, test, or gate to specific evidence.
- Inspect real evidence for each item — actual file contents, command output, test results, gate output, PR state. Not "I implemented it" — "here is the file at this path showing it."
- Verify proxies actually cover the requirement. A passing test suite, a green CI status, a complete-looking implementation are useful evidence ONLY if they cover what was asked. A test that passes but doesn't exercise the new code is not coverage. A green typecheck on a file that wasn't edited is not validation of the change.
- Treat uncertainty as not-done. If you can't verify an item with evidence, the item is NOT DONE. Do more verification or continue the work.
Do not rely on any of the following as proof of completion:
- Intent — "I meant to do X" is not "X is done"
- Partial progress — "I started X" is not "X is complete"
- Elapsed effort — "I spent time on X" is not "X works"
- Memory of earlier work — re-verify; the state may have changed
- A plausible final answer — fabricated test output, hallucinated file contents, or a confident summary that wasn't checked against reality is the canonical failure mode this skill exists to prevent
These clauses address two documented Mycelium failures: Eval Overfitting (2026-04-30 — agent encoded eval answers into documentation to "pass," gaming the proxy instead of checking the criterion) and SessionStart relay leak (2026-05-02 — agent declared turns complete while skipping protocol steps). Borrowed from OpenAI Codex /goal continuation template's completion-audit specification (logged 2026-05-03).
Checklist
Functionality
Code Quality
Testing
Security
Accessibility
Documentation
Observability
Deployment
Process
MoSCoW Scope Compliance (DSDM)
AI Feature Contract (product_type: ai_tool ONLY)
Skip this entire section unless diamonds/active.yml declares product_type: ai_tool. An AI feature is a behavioral contract, not a spec: it is judged on success thresholds, failure modes, and must-never constraints rather than line-item functionality. These criteria do NOT apply to software / content / service products — do not let them bleed into the product-agnostic checklist above.
Mechanised proxy check — run these before ticking anything
The anti-bias clause above says "a test that passes but doesn't exercise the new
code is not coverage." That sentence has been in this skill as prose, and prose
does not fail a build. Three shipped guards now decide it mechanically. Run them
from the project root and paste the output as the evidence for the "tests" and
"mechanisms wired" items — an unrun guard is the same false green it was written
to catch.
python3 "${CLAUDE_PLUGIN_ROOT}/scripts/check_wiring.py" --root .
python3 "${CLAUDE_PLUGIN_ROOT}/scripts/check_negative_control.py" --root .
python3 "${CLAUDE_PLUGIN_ROOT}/scripts/check_test_authenticity.py" --root .
Each answers a different question, and passing one says nothing about the others:
| Guard | Question | The failure it catches |
|---|
check_wiring | Does anything CALL this mechanism? | Shipped, documented "auto-updated", invoked by nothing |
check_negative_control | Could this guard FAIL? | A check that is green because it can only be green |
check_test_authenticity | Does production code RUN when the test runs? | A test that imports nothing, asserts a tautology, or mocks away the thing it names |
Non-zero exit is a NOT-DONE, not a warning. Each prints the specific file and
line; fix the finding or state the exemption with a reason. "It is hard to check"
is not a reason.
Why this belongs at the moment of claiming done rather than in CI alone. The
failure class is "built, not wired": an artefact whose tests pass, whose coverage
rises, and which nothing calls. Every local signal an agent uses to decide it is
finished — tests green, file written, coverage up — is blind to wiring, because
wiring is a property of a PAIR and every default tool verifies a thing against
itself. So the completion signal fires before the work is connected. These guards
move that discovery from "months later, if ever" to "before the box gets ticked".
Outcome
- DONE: All required items checked. Proceed.
- NOT DONE: List failing items. Address before marking complete.
Theory Citations
- Forsgren: Accelerate (deployment practices)
- Smart: Sooner Safer Happier (BVSSH)
- Downe: Good Services (quality)
- OWASP: Security
- WCAG: Accessibility
- AI Feature Contract: AI PRD as behavioral contract — success thresholds, evidence-derived failure modes, must-never constraints (Adaline 2026)