ase-repo-review

@${CLAUDE_SKILL_DIR}/../../meta/ase-control.md @${CLAUDE_SKILL_DIR}/../../meta/ase-skill.md @${CLAUDE_SKILL_DIR}/../../meta/ase-getopt.md

<purpose name="ase-repo-review"> Review Changes </purpose>

<expand name="getopt" arg1="ase-repo-review" arg2="--severity|-S=(AUTO|LOW|MEDIUM|HIGH) --thorough|-t --working-copy|-w --branch|-b= --commit|-c="> $ARGUMENTS </expand>

<objective> Review the currently staged (or all uncommitted) Git changes, the changes of a branch against its base, or a single commit the way an *experienced human reviewer* would - judging them *holistically* against the change's *own intent* and against *correctness*, *design fit*, *clarity*, *robustness*, *propagation*, freedom of *residue*, and *project-convention conformance* - and emit a single *approve / request-changes verdict* backed by *prioritized*, *severity-tagged*, *line-cited* findings. This is a *synthesizing critique*, not a mechanical scan: it complements `ase-code-lint` (mechanical quality), `ase-code-analyze` (logic/semantics), and `ase-repo-diff` (intent narrative and risk). </objective>

Procedure

<flow>

1. <step id="STEP 1: Determine Change Set">
   1. <if condition="<getopt-option-commit/> is not empty and (<getopt-option-branch/> is not empty or <getopt-option-working-copy/> is equal `true`)"> Only output the following <template/> and then *STOP* immediately: <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ▶ ERROR: option `--commit` cannot be combined with `--branch` or `--working-copy` </template> </if>
   2. <if condition="<getopt-option-branch/> is not empty"> Determine the *base* of the branch:

      1. Run the command git rev-parse --verify --quiet "<getopt-option-branch/>^{commit}". If it fails, only output the following <template/> and then STOP immediately:

         <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ▶ ERROR: branch **<getopt-option-branch/>** does not exist </template>

      2. Determine the candidate base branches by running the command git for-each-ref --format="%(refname:short)" refs/heads/ (taken exactly as given), excluding <getopt-option-branch/> itself. For each <candidate/>, run the command git rev-list --count "<candidate/>..<getopt-option-branch/>" to count the commits of the branch since its fork point from <candidate/>, and drop every candidate with a count of 0, as it already contains the branch. Set <base/> to the remaining candidate with the smallest count (the nearest fork point); on a tie, prefer the checked-out branch (the output of git branch --show-current), and then the first candidate. If no candidate remains, only output the following <template/> and then STOP immediately:

         <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ▶ ERROR: no base branch determinable for branch **<getopt-option-branch/>** </template>

      3. Run the command git merge-base "<base/>" "<getopt-option-branch/>" and capture its output into <base-commit/>.

      4. Only output the following <template/>:

         <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ⎇ branch: **<getopt-option-branch/>**, ⎇ base: **<base/>** </template>
      </if> <elseif condition="<getopt-option-commit/> is not empty"> Run the command `git rev-parse --verify --quiet "<getopt-option-commit/>^{commit}"` and capture its output into <commit-id/>. If it fails, only output the following <template/> and then *STOP* immediately: <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ▶ ERROR: commit **<getopt-option-commit/>** does not exist </template> </elseif>

   3. Determine whether there are changes at all by running the corresponding command(s) (taken exactly as given) and capturing their combined output - the bare list of changed file names - into <diff/>. This is a lightweight gate; the full diff is fetched by the sub-agent in STEP 2, so capturing only the file-name list here is sufficient:

      <if condition="<getopt-option-branch/> is not empty and <getopt-option-working-copy/> is equal `true`"> Determine the *worktree* of the branch by running the command `git worktree list --porcelain` and setting <worktree-dir/> to the `worktree` path of the entry whose `branch` line is `refs/heads/<getopt-option-branch/>` (or to empty if there is none, as a branch not checked out anywhere carries no uncommitted changes).

      If <worktree-dir/> is not empty, set <scope>branch <getopt-option-branch/> since base commit <base-commit/> plus the uncommitted changes in worktree <worktree-dir/></scope> and run:

      git -C "<worktree-dir/>" diff --name-only "<base-commit/>"

      git -C "<worktree-dir/>" ls-files --others --exclude-standard

      From the output of the second command, skip every listed entry below the .ase/ directory -- it carries ASE's own state, and hence is never part of the user's change set.

      Otherwise, set <scope>branch <getopt-option-branch/> since base commit <base-commit/></scope> and run:

      git diff --name-only "<base-commit/>..<getopt-option-branch/>" </if> <elseif condition="<getopt-option-branch/> is not empty"> Set <scope>branch <getopt-option-branch/> since base commit <base-commit/></scope> and run:

      git diff --name-only "<base-commit/>..<getopt-option-branch/>" </elseif> <elseif condition="<getopt-option-commit/> is not empty"> Set <scope>commit <commit-id/></scope> and run:

      git show --format= --name-only --diff-merges=first-parent "<commit-id/>" </elseif> <elseif condition="<getopt-option-working-copy/> is equal `true`"> Set <scope>working copy</scope> and run:

      git diff --name-only HEAD

      git ls-files --others --exclude-standard

      From the output of the second command, skip every listed entry below the .ase/ directory -- it carries ASE's own state, and hence is never part of the user's change set. </elseif> <else> Set <scope>staged</scope> and run:

      git diff --cached --name-only HEAD </else>

   4. <if condition="<diff/> is empty"> Only output the following <template/> and then *STOP* immediately: <template> ⧉ **ASE**: ✪ skill: **ase-repo-review**, ▶ status: **no changes to review** </template> </if>
   </step>
2. <step id="STEP 2: Review Investigation"> <if condition="<ase-project-boxing/> is equal `black`">

   The project source artifacts are classified as a black box, so the user does not want the changes scrutinized or their findings surfaced. Skip the entire review investigation: do not invoke the Agent tool and do not read any change, set <findings/> to the empty list, set <hidden/> to 0, set <verdict/> to SKIPPED (boxing: black), set <summary/> to a one-line neutral restatement of the change intent derived solely from STEP 1, and proceed directly to STEP 3.

   </if>

   First, use the following <template/> to give a hint on this step:

   <template> <ase-tpl-bullet-secondary/> **REVIEW INVESTIGATION** </template>

   Dispatch the review investigation to a sub-agent via the Agent tool so that no investigation details leak into the user-visible transcript. The sub-agent performs the silent reading, the read-only repository probing, and the critique; only its final structured return value is consumed here.

   Set <mode>thorough</mode> if <getopt-option-thorough/> is equal true, and <mode>focused</mode> otherwise.

   For this, invoke exactly once the tool:

       Agent(
           description:       "Review Investigation",
           subagent_type:     "ase:ase-repo-review",
           prompt:            "Review in <mode/> mode the changes of scope: <scope/>",
           run_in_background: false
       )
   

   Parse the single result message of the Agent tool as a JSON object, set <summary/> to its summary field (a single crisp sentence reconstructing the change's intent), and set <findings/> to its findings field (a list).

   Then derive the overall <verdict/> from <findings/>: set <verdict/> to REJECT - DEMANDS CHANGES if any finding in <findings/> has a severity field of HIGH; otherwise set <verdict/> to APPROVE. The verdict is derived before the severity floor below, so the floor only affects which findings are rendered, never the verdict.

   Then determine the effective severity floor <floor/> and its origin <floor-origin/>: define the ordinal rank LOW=1, MEDIUM=2, HIGH=3.

   <if condition="<getopt-option-severity/> is equal `AUTO`"> Set <floor>MEDIUM</floor> and <floor-origin>boxing: grey</floor-origin> if <ase-project-boxing/> is equal `grey` (grey boxing surfaces only *material* findings of severity `MEDIUM` and above), and <floor>LOW</floor> and <floor-origin>default</floor-origin> otherwise. </if> <else> Set <floor><getopt-option-severity/></floor> and <floor-origin>--severity <getopt-option-severity/></floor-origin>: an *explicitly* given severity floor always *wins* over the boxing. </else>

   Then apply the effective severity floor <floor/>: Keep a finding in <findings/> if and only if its severity field is ACCEPTED or rank(severity) is greater than or equal to rank(<floor/>); drop all other findings, but set <hidden/> to the number of dropped findings. With the floor LOW, all findings are kept. ACCEPTED findings are never dropped. The floor affects only which findings are rendered, never the <verdict/> derived above.

   You MUST NOT output anything else in this STEP 2.

   </step>
3. <step id="STEP 3: Verdict and Findings">

   1. Use the following <template/> to output the overall review in <verdict/> and the reconstructed intent <summary/>:

      <template>

      <ase-tpl-bullet-signal/> REVIEW VERDICT: <verdict/>

      <ase-tpl-bullet-normal/> CHANGE INTENT: <summary/>

      </template>

      You MUST NOT output anything else in this STEP 3.1.

   2. <if condition="<findings/> is empty"> Only output the following <template/> - with <note/> set to `the change was not reviewed` if <verdict/> starts with `SKIPPED`, to `no finding reaches severity <floor/>` if <hidden/> is greater than `0`, and to `the change is clean` otherwise - and then *SKIP* substep 3 of this STEP 3: <template>

      <ase-tpl-bullet-normal/> NO FINDINGS: <note/>, nothing to flag.

      </template> </if>
   3. <if condition="<findings/> is NOT empty"> Sort the findings by <severity/> from highest to lowest in the fixed order `HIGH`, `MEDIUM`, `LOW`, `ACCEPTED`. Within the same severity, keep the order returned by the sub-agent.

      Then render a three-column table with one row per finding by using the following output <template/>. For each finding, repeat the third line, set <severity/> to its severity field, set <dimension/> to its dimension field, set <location/> to its location field, and set <finding/> to its finding field.

      In the <location/> column, mark up the file:line reference as code (with backticks) and prepend it with ▢ - keep the sub-agent's own :N / :N-M line citation intact and do not append any further line-count decoration.

      Because the <finding/> text is free-form Markdown, before emitting any row you MUST escape every literal | pipe character inside <location/> and <finding/> as \| so it cannot break the table column structure.

      <template> | Severity | Dimension | Finding | | --------------- | ------------ | ----------------------- | | **<severity/>** | <dimension/> | <location/>: <finding/> | </template>

      Keep the overall report concise and brief. Do not output any further explanation. </if>

   4. <if condition="<hidden/> is greater than `0`"> Output the following <template/>, so that suppressed findings are never mistaken for a clean change: <template>

      <ase-tpl-bullet-normal/> HIDDEN FINDINGS: <hidden/> finding(s) below severity <floor/> suppressed (<floor-origin/>).

      </template> </if>

   5. Finally, give the closing hints by expanding the following (which, depending on the configured <ase-guidance-level/>, may expand into nothing and hence emit no output at all):

      <if condition="<verdict/> starts with `REJECT`"> <ase-tpl-hint level="normal"> Use `/ase-code-resolve` to derive and apply a solution approach for the findings which demand changes. </ase-tpl-hint> </if> <if condition="<hidden/> is greater than `0`"> Set <rerun>/ase-repo-review -S LOW</rerun>, append ` -w` to <rerun/> if <getopt-option-working-copy/> is equal `true`, append ` -b <getopt-option-branch/>` to <rerun/> if <getopt-option-branch/> is not empty, append ` -c <getopt-option-commit/>` to <rerun/> if <getopt-option-commit/> is not empty, and append ` -t` to <rerun/> if <getopt-option-thorough/> is equal `true`, so that the re-run reviews the same scope in the same mode. <ase-tpl-hint level="normal"> Use `<rerun/>` to re-run the review with all findings shown (a fresh review, so its findings can differ). </ase-tpl-hint> </if>
   </step>

</flow>