跳到正文
cccskills
免费在 GitHub 公开

design-smell-review

Lightweight design smell review for modules and APIs—coupling, cohesion, naming, boundaries, and unnecessary complexity. Use before large refactors or when code feels hard to change. Complements gstack/review (diff-focused).

中文简介正在准备中。当前显示原文说明。

实测评分 未实测

查看安装方法

包含的文件(1)

  • SKILL.md2.0 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Design smell review

Scope

Review structure and boundaries, not line-by-line style. Pair with PR diff review for changes; use this for module-level health.

Smell checklist

SmellSignalDirection
God moduleMany unrelated responsibilitiesSplit by domain
Shotgun surgeryOne change touches many filesConsolidate logic
Feature envyModule A mostly uses B's dataMove behavior
Leaky abstractionImpl details escape APINarrow public surface
Config soupMagic strings everywhereNamed constants / schema
Boolean flagsif is_x branches everywherePolymorphism or strategy

Workflow

  1. Map entry points and dependencies (imports, public API).
  2. List responsibilities per module; flag >1 unrelated core job.
  3. Check testability — can core logic run without I/O?
  4. Propose smallest structural improvement (not full rewrite).
  5. Record decision in ADR if trade-off is significant.

Output format

## Summary
[1-2 sentences]

## Smells (priority order)
1. [Smell] — evidence — suggested fix (effort: S/M/L)

## Recommended next step
[One concrete change to try first]

Simplification (Chesterton's Fence)

Before deleting or collapsing code, ask why it exists:

  • Comment, test, or git history explaining constraint?
  • If unknown, prefer small experiment or question over bulk delete.
  • Remove duplication only when behavior is proven identical.
  • "Fewer lines" is not success if edge cases or observability regress.

Boundaries

  • Do not block small fixes on perfect architecture.
  • Prefer incremental extraction over big-bang rewrites.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

"Implement and select ad bidding strategies from manual CPC to automated target-CPA and target-ROAS. Use this skill when the user needs to choose a bidding strategy, set up automated bidding, or optimize bid parameters — even if they say 'what bidding strategy should I use', 'target CPA setup', or 'smart bidding configuration'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

"Optimize advertising budget allocation across campaigns using marginal returns analysis. Use this skill when the user needs to distribute budget across multiple campaigns, optimize spend pacing, or maximize overall ROAS under budget constraints — even if they say 'how to split my ad budget', 'campaign budget optimization', or 'diminishing returns on ad spend'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

"Build CTR prediction models for estimating ad click-through rates from features. Use this skill when the user needs to predict click probability, build an ad ranking model, or evaluate ad creative performance — even if they say 'predict click rate', 'ad relevance scoring', or 'which ad will get more clicks'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

"Implement Generalized Second Price auction for ad slot allocation and pricing. Use this skill when the user needs to understand search ad auctions, compute ad positions and costs-per-click, or analyze bidding dynamics — even if they say 'how does Google Ads auction work', 'ad rank calculation', or 'second price auction for ads'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

"Implement VCG mechanism for incentive-compatible ad slot allocation with truthful bidding. Use this skill when the user needs to design a truthful auction mechanism, compute externality-based payments, or understand why platforms may prefer GSP over VCG — even if they say 'truthful auction design', 'VCG payments', or 'incentive-compatible mechanism'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

"Explain blockchain fundamentals including distributed ledger architecture, consensus mechanisms, and block structure. Use this skill when the user needs to understand blockchain concepts, evaluate whether blockchain fits a use case, or design a blockchain-based solution — even if they say 'how does blockchain work', 'do I need blockchain', or 'distributed ledger'.".

中文简介正在准备中。当前显示原文说明。

charlieviettq/awesome-agent-skill262026年7月20日 更新

查看 charlieviettq 的全部技能

报告此技能的问题