跳到正文
cccskills
免费在 GitHub 公开

review-code-smells

Review touched code for maintainability smells such as duplication, awkward indirection, suspicious clones, dead code, poor naming, and Boy Scout cleanup opportunities. Use when a broad review needs a dedicated maintainability pass or when the user asks for code-smell review specifically.

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md2.1 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Review Code Smells — Incan Compiler

Purpose

/review-code-smells is a file-focused report-only reviewer for local maintainability issues.

Own:

  • duplication
  • dead code
  • awkward or unnecessary indirection
  • suspicious clones
  • poor naming in touched code
  • touched-code cleanup opportunities that satisfy the Boy Scout rule

Do not own:

  • architecture-level placement decisions
  • docs truthfulness
  • test style details
  • final branch-clean judgment

Output artifact

Write a slice report at:

  • .agents/state/review-report.code-smells.md

Do not write to the canonical .agents/state/review-report.md.

Workflow

  1. Review the touched code files assigned by the orchestrator.
  2. Flag:
    • duplicated branches or helpers
    • no-op/unused/dead surfaces
    • awkward APIs or naming in touched code
    • needless complexity relative to the actual requirement
  3. Keep this pass practical. Do not invent refactors unrelated to the touched surface.
  4. Classify each finding as either:
    • maintainability
    • design-tension
    • or bug This classification is for downstream handling only. It must not be used to hide the finding.

Slice report shape

Keep slice reports findings-first. Only list clean surfaces when that clean call is non-obvious or useful for the orchestrator.

# Review Slice Report

- role: code-smells
- worker: <agent-id or stable label>
- status: in_progress | clean | blocked

## Scope
- assigned files:
  - loaves/toolchain/incan-cli/src/lib.rs

## Findings

- [ ] warning | maintainability | dead cli surface | loaves/toolchain/incan-cli/src/lib.rs:313
  `--bin` is exposed publicly but has no effect.

## Reviewed Clean Surfaces
- loaves/toolchain/incan-cli/src/commands/init.rs — maintainability reviewed; no findings

If there are no findings, say so explicitly.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Add a new learning to the agent learnings file. Use when the user says /add-learning, asks to record a lesson, or when an implementation produced a reusable insight worth preserving for future agents.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

bump-rfc

免费

Transition an Incan RFC from one status to the next. Use when the user asks to promote, advance, or finalize an RFC, or says /bump-rfc. Handles Draft → Planned, Planned → In Progress, and In Progress → Implemented transitions.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

closeout

免费

Safely close out completed Incan work after a PR is merged by verifying merge status, syncing the base branch, removing task-owned local worktrees/assets, deleting merged local/remote branches, pruning refs, and reporting dirty or ambiguous leftovers. Use when the user says /closeout, asks to clean up after a merged PR, or wants local RFC/issue branch/worktree cleanup.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

Drafts a GitHub issue title and body using the target repository's issue templates under .github/ISSUE_TEMPLATE. Use when the user asks to create, draft, or file a GitHub issue, bug report, feature request, chore, documentation issue, or RFC proposal, or wants issue text that matches the repo's template.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

Drafts implementation plans with TDD, documentation updates, and repository verification commands before coding. Use when the user asks for an implementation plan, /create-plan, or structured pre-implementation design for work in encero workspaces (e.g. Incan, IncQL).

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

Generate a PR description following the repository's pull request template. Use when the user asks to create, draft, or generate a PR description for a pull request. The skill automatically locates the PR template in the target repository and fills it in based on the git diff.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan652026年10月19日 更新

查看 encero-systems 的全部技能

报告此技能的问题