跳到正文
cccskills
免费在 GitHub 公开

review-test-style

Review touched tests and test-adjacent code for style, Result-returning patterns, panic helpers, unwrap/expect use, and obvious coverage gaps. Use when a broad review needs a dedicated test pass or when the user asks for test-review specifically.

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md2.3 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Review Test Style — Incan Compiler

Purpose

/review-test-style is a narrow report-only reviewer for touched tests and code changes that imply missing test coverage.

Own:

  • panic helpers and panic-style control flow in touched tests
  • unwrap/expect in tests
  • fallible tests not returning Result
  • obvious missing targeted coverage for new behavior

Do not own:

  • rustdoc prose
  • docs truthfulness
  • architecture
  • final branch-clean judgment

Output artifact

Write a slice report at:

  • .agents/state/review-report.test-style.md

Do not write to the canonical .agents/state/review-report.md.

Workflow

  1. Review the touched tests and the code changes that should have tests.
  2. Flag:
    • .unwrap() / .expect() in tests
    • panic!-driven helper/control flow where Result + assertions would be clearer
    • missing targeted tests for new CLI, lifecycle, or semantic behavior
    • stale snapshots or missing integration coverage when behavior changed end-to-end
  3. Only flag a coverage gap when the new behavior or branch is not exercised anywhere in the touched tests. If integration coverage already exercises the behavior, do not demand redundant parser/unit duplication without a concrete reason.
  4. Keep this pass focused on test quality and coverage, not general code quality.

Slice report shape

Keep slice reports findings-first. Only list clean surfaces when they are materially useful to the orchestrator.

# Review Slice Report

- role: test-style
- worker: <agent-id or stable label>
- status: in_progress | clean | blocked

## Scope
- assigned files:
  - loaves/toolchain/incan-cli/tests/integration_tests.rs

## Findings

- [ ] warning | test-gap | panic helper | loaves/toolchain/incan-cli/src/lib.rs:84
  Test helper uses panic-oriented control flow instead of `Result` + assertions.

## Reviewed Clean Surfaces

- loaves/toolchain/incan-cli/tests/integration_tests.rs — touched lifecycle coverage reviewed; no additional findings

If there are no findings, say so explicitly.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Add a new learning to the agent learnings file. Use when the user says /add-learning, asks to record a lesson, or when an implementation produced a reusable insight worth preserving for future agents.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

bump-rfc

免费

Transition an Incan RFC from one status to the next. Use when the user asks to promote, advance, or finalize an RFC, or says /bump-rfc. Handles Draft → Planned, Planned → In Progress, and In Progress → Implemented transitions.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

closeout

免费

Safely close out completed Incan work after a PR is merged by verifying merge status, syncing the base branch, removing task-owned local worktrees/assets, deleting merged local/remote branches, pruning refs, and reporting dirty or ambiguous leftovers. Use when the user says /closeout, asks to clean up after a merged PR, or wants local RFC/issue branch/worktree cleanup.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

Drafts a GitHub issue title and body using the target repository's issue templates under .github/ISSUE_TEMPLATE. Use when the user asks to create, draft, or file a GitHub issue, bug report, feature request, chore, documentation issue, or RFC proposal, or wants issue text that matches the repo's template.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

Drafts implementation plans with TDD, documentation updates, and repository verification commands before coding. Use when the user asks for an implementation plan, /create-plan, or structured pre-implementation design for work in encero workspaces (e.g. Incan, IncQL).

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

Generate a PR description following the repository's pull request template. Use when the user asks to create, draft, or generate a PR description for a pull request. The skill automatically locates the PR template in the target repository and fills it in based on the git diff.

中文简介正在准备中。当前显示原文说明。

encero-systems/incan662026年10月22日 更新

查看 encero-systems 的全部技能

报告此技能的问题