跳到正文
cccskills
免费在 GitHub 公开

review-changes

Load when asked to review a local diff/change set for correctness, regressions, blast radius, affected flows, and missing tests using the knowledge graph; use `review-pr` for intent/checklist/merge-gate evidence.

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md3.3 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

<!-- ABOUTME: Two-axis risk-aware diff review using Fowler smells, flow, impact, and coverage evidence. --> <!-- ABOUTME: Evaluates Standards and Spec Fidelity independently so clean code does not mask missed requirements. -->

Review Changes: Two-Axis Code Review

Review local diffs across two independent, non-polluting axes:

  1. Axis 1 (Standards & Smells): Does the code adhere to Clean Architecture, repo rules, and the Fowler Smells Baseline?
  2. Axis 2 (Spec & Intent Fidelity): Does the diff faithfully satisfy the requested behavior without scope creep or missed edge cases?

The Fowler 12-Smell Baseline

Evaluate the diff against these 12 classic code smells:

Code SmellWhat It IsHow to Correct
Mysterious NameTypes, methods, or variables whose names do not reveal intent.Rename to match domain glossary.
Duplicated CodeSame logic shape recurring across multiple files/handlers.Extract to shared domain/application method.
Feature EnvyA method accessing another object's data more than its own.Move method onto the owning data/aggregate.
Primitive ObsessionRaw string/int standing in for domain concepts (e.g. email, status).Encapsulate in strongly typed value object/enum.
Data ClumpsSame 3+ parameters traveling together across methods.Bundle into a record or parameter object.
Shotgun SurgeryOne logical change forcing scattered edits across unrelated files.Consolidate cohesion in owning module.
Divergent ChangeOne class modified for multiple unrelated reasons.Split class by single responsibility.
Speculative GeneralityUnused abstractions, generic hooks, or parameters not needed yet.Delete; keep code minimal (YAGNI).
Message ChainsLong a.B.C.D property walks violating Demeter's Law.Hide navigation behind a method on first object.
Middle ManA class/handler that merely delegates without adding value.Cut middle man; call target directly.
Repeated SwitchesRepeated switch/if cascades on the same enum/type.Replace with polymorphism or strategy pattern.
Refused BequestA subclass ignoring or overriding most inherited behavior.Replace inheritance with composition.

Review Workflow

  1. Run detect_changes_tool to get risk-scored change analysis.
  2. Run get_affected_flows_tool to find impacted execution paths.
  3. For each high-risk symbol, run query_graph_tool with pattern="tests_for" to check test coverage.
  4. Run get_impact_radius_tool to understand blast radius.
  5. Report findings under two distinct headings: ## Standards & Code Smells and ## Spec & Intent Fidelity.

Token Efficiency Rules

  • ALWAYS start with get_minimal_context(task="<your task>") before any other graph tool.
  • Use detail_level="minimal" on all calls. Only escalate to "standard" when minimal is insufficient.
  • Target: complete any review/debug/refactor task in ≤5 tool calls and ≤800 total output tokens.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Load for Blazor/MudBlazor UI changes involving forms, dialogs, focus, keyboard navigation, landmarks, ARIA, color contrast, RTL-safe styling, or WCAG 2.2 AA tests; not for backend-only changes.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

Load when a task asks to research, verify, compare, or look up framework/package behavior, release notes, standards, RFCs, CVEs, or unfamiliar APIs; use repository evidence first, then official docs, and not for codebase navigation alone.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

aspire

免费

Load for Aspire AppHost work: start/stop/wait resources, inspect dashboard/logs/traces, add integrations/resources, rebuild a service, run isolated worktrees, or diagnose Aspire orchestration; not for plain dotnet apps, container-only deployments, or cloud deployment.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

Load for authentication or authorization changes involving BFF cookies/tokens, JWT validation, claims/user ID extraction, policies, handler access checks, impersonation, or 401/403 bugs; not for UI affordance gating alone.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

Load for Blazor BFF server work involving YARP proxy routes, cookie sessions, access-token forwarding/refresh, downstream API calls, BFF handlers, or browser-to-API auth failures; not for client component rendering or API JWT validation alone.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

Load when editing Blazor `.razor.css`, scoped selectors, `::deep`, BEM class names, RTL/logical CSS properties, or styling nested MudBlazor components; not for global design tokens or non-Blazor CSS.

中文简介正在准备中。当前显示原文说明。

islamu-ngo/Event82026年10月20日 更新

查看 islamu-ngo 的全部技能

报告此技能的问题