跳到正文
cccskills
免费在 GitHub 公开

review

Deep code review - Elixir idioms, Phoenix patterns, architecture, safety. Launches 3 parallel reviewers + plan-reviewer gate. Use when: review, review this, code review, check this code, review my changes, is this good, what do you think, code smells.

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md2.7 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Code Review — Parallel Agents + Plan-Reviewer Gate

Reviews current changes for correctness, idioms, architecture, and Phoenix/LiveView patterns. Three parallel code-reviewer agents with focused scopes, aggregated findings, and a plan-reviewer critique before presenting fixes.

Workflow

Phase 1: Diff

Get the full diff and diff stat against main:

git diff main...HEAD
git diff main...HEAD --stat

Phase 2: Parallel Review

Launch 3 code-reviewer agents in parallel (single message, 3 Agent tool calls). Each gets the full diff but a focused mandate.

CRITICAL: Launch all 3 agents in the same message so they run concurrently.

Agent 1: Correctness & Safety

Focus: logic bugs, Ecto changeset errors, LiveView callback correctness, edge cases (nil, empty, missing records), query correctness, transaction safety.

Agent 2: Idioms & Architecture

Focus: Elixir idioms (multi-clause over if/else, no unless, no nested case), Phoenix patterns (contexts as boundary, thin LiveView, streams), DDD boundaries (Blog/Import/Export), module size <200 lines.

Agent 3: Completeness & Contracts

Focus: test coverage for new public functions, CLAUDE.md sync with actual structure, comment quality (WHY not WHAT), proper validations in changesets.

Phase 3: Aggregate

After all 3 agents return, merge findings:

  1. Merge into unified tiers (Critical / Important / Minor / Positive)
  2. Deduplicate same file:line across agents
  3. Tag each finding with source: [safety], [idioms], [completeness]
  4. Cap: max 5 Critical, 7 Important, 3 Minor
  5. Verdict: any Critical or Important -> "Needs fixes"; only Minor/Positive -> "Clean with suggestions"

Phase 4: Plan + Critique

If Critical or Important findings exist:

  1. Build a numbered fix plan
  2. Launch a plan-reviewer agent to critique the fix plan
  3. Incorporate critique: drop over-engineered fixes, add missed gaps
  4. Present the critique-adjusted plan to the user

If only Minor findings: skip plan-reviewer, present review directly.

Phase 5: Present

Show the aggregated review to the user with verdict and fix plan if needed.

Phase 6: Implement

After user approves the plan:

  1. Implement fixes in plan order
  2. Run verification:
    mix test
    mix format --check-formatted
    mix compile --warnings-as-errors
    
  3. Report results

Pipeline

/dev <issue> -> /review -> /commit -> /pr

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

commit

免费

Create a git commit following project conventions. Use when: commit, commit this, make a commit, commit changes, git commit, save changes, commit my work, stage and commit, detailed commit.

中文简介正在准备中。当前显示原文说明。

leandronsp/curupira222026年3月21日 更新

dev

免费

Implementer - fetches a GitHub issue, builds an implementation plan, then implements using TDD. Use when: implement, build this, code this, add this feature, TDD, test first, red green refactor, pick a task, next task, dev.

中文简介正在准备中。当前显示原文说明。

leandronsp/curupira222026年3月21日 更新

po

免费

Product Owner - scans codebase and creates or amends GitHub issues with PRD. Use when: PRD, feature, issue, create issue, amend issue, what should we build, plan feature, design feature, scope, requirements.

中文简介正在准备中。当前显示原文说明。

leandronsp/curupira222026年3月21日 更新

pr

免费

Open or update a draft PR for the current branch. Use when: create PR, open PR, draft PR, pull request, prepare for review.

中文简介正在准备中。当前显示原文说明。

leandronsp/curupira222026年3月21日 更新

查看 leandronsp 的全部技能

报告此技能的问题