跳到正文
cccskills
免费在 GitHub 公开

design-review

Use when a design task asks you to compare a built screen with its approved design - screenshots at 1440, 768 and 375 attached to the task, Blocker/High/Medium/Nitpick triage, evidence per finding, problems not prescriptions

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md4.7 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Design Review

Overview

A design review answers one question: does the built screen match the design the human approved? It is a comparison against a contract, not a fresh critique — taste that is not in the approved design is not a finding. You report problems; the developers decide the fix.

Core principle: Same widths, same states, side by side — every finding cites what the approved design says and what the build shows.

Inputs

  • The approved design: the design task this review points at (its key is in the description, blocked_by or derived_from; its documents are in your context under "## The approved design this task builds" when this task is blocked by it) — list_task_documents <key>: the handoff: <screen> spec, which names the chosen design: <screen> · <letter> mockup, and that mockup (raw: true for its source, to render it). The other variant documents were not chosen; never review against them.
  • The built screen: the URL the description names (a preview or staging address), or the app started locally the way get_project_brief says — detached, its log under /tmp/tt-<task key>/, on loopback. Installing dependencies to run it is not a change; editing a source file is.
  • get_design_system for the repository — the tokens the build must use.

Procedure

  1. Render the approved mockup (screen-mockup-html's self-check) and open the built screen in the same browser session, one after the other.
  2. At each width — browser_set_viewport {device: "desktop"} (1440), {device: "tablet"} (768), {device: "mobile", width: 375} — browser_screenshot the built page (full_page: true, no width, attach_to_task: true, title: "<screen>-built-<width>", plus -<state> for a state: invoices-built-375-empty) and the matching mockup frame (no need to attach it — it is on the design task already).
  3. Reach every state the build allows from the outside: an empty search, a filter with no results, an invalid form submit, the error a disconnected API produces if the brief names one. A state you cannot reach is listed as "not reviewed", never assumed to match.
  4. Compare in this order: layout and hierarchy → content and exact copy → components (the right one, the right variant) → tokens (colour, type, spacing, radius — browser_read_dom with as_text: false shows the classes an element carries) → states → responsive behaviour → visible accessibility (labels, focus ring, text alternatives, touch target size).
  5. Triage every difference:
SeverityMeansExample
Blockerthe screen fails the approved design on a core paththe primary action is missing at 375; the layout breaks at 768; body text fails contrast
Higha deviation users will notice, or a design-system violationwrong component; an off-token colour; a missing empty state; key copy wrong
Mediumnoticeable, minorspacing one step off; secondary copy paraphrased; alignment
Nitpickpolishicon optical alignment; a 1px border difference
  1. Write each finding as a problem, not a prescription: what the approved design says (#a-375-empty, or the hand-off line), what the build shows, where (URL + viewport + region). "Overdue status is shown by colour alone; the approved design pairs it with the word Overdue (handoff: Accessibility)" — not "add a span to InvoiceRow.tsx".

The document

ONE document on the design task, titled design review: <screen>: a verdict line at the top (matches / does not match, counts per severity), the findings table (id · severity · width · where · expected · actual · screenshot), the states not reviewed and why, and one line on what matches. Each finding's evidence is the attached screenshot by its title, the URL, the viewport and what the screenshot showed; say them exactly — a title, never a path.

Then stop like any design task. On approval (done), the Blocker and High findings become one bug task per repository; Medium and Nitpick stay in the document unless the human asked for them.

Common Mistakes

  • Reviewing against your own taste instead of the approved design.
  • Comparing the 1440 build with the 375 mockup frame.
  • Prescribing code ("change the class to …") instead of naming the gap.
  • Calling a state "fine" that you never managed to open.

Red Flags

  • A finding with no width, no URL or no attached screenshot.
  • Every finding rated Blocker — or none rated anything but Nitpick on a screen that visibly differs.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Use when writing acceptance criteria for a task - express each as an observable Given/When/Then that QA can execute, including negative cases

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

Use when the diff adds or changes an endpoint, resolver, RPC, job or query that takes an object id, a role check, a request binding or a tenant filter - BOLA/IDOR, function-level authorization, mass assignment and tenant scoping

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

Use on every UI change - semantic HTML, labels for controls, keyboard-navigable dialogs/menus, visible focus, and never color as the only signal

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

Use when a task changes any screen, form, dialog, menu or control - Lighthouse/axe scan of the changed screens, a keyboard walk, and the thresholds that fail a task

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

How to work a task returned with review, QA or UAT findings. Use when a task is in need_revision or PR review comments are in your context.

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

Use when the repository keeps its alerting in code, or a person asks for alerts outside TaskTrooper - PrometheusRule YAML, a Cloud Monitoring alert policy in Terraform, a Datadog monitor, each routed to TaskTrooper's alert ingest URL so it opens an incident here

中文简介正在准备中。当前显示原文说明。

makifbaysal/tasktrooper1172026年10月21日 更新

查看 makifbaysal 的全部技能

报告此技能的问题