跳到正文
cccskills
免费在 GitHub 公开

receiving-code-review

Evaluate code review feedback against the actual code, supported environments, and existing behavior. Clarify uncertain requests, respond with technical evidence, and implement valid changes one at a time with tests for each fix.

中文简介正在准备中。当前显示英语简介。

原文查看原文说明

Use when receiving code review feedback, before implementing suggestions, especially if feedback seems unclear or technically questionable - requires technical rigor and verification, not performative agreement or blind implementation

查看安装方法

适用场景

  • Clarifying ambiguous code review comments
  • Checking whether suggested changes preserve compatibility
  • Assessing whether a requested feature is actually used
  • Applying multiple review fixes with individual tests

包含的文件(1)

  • SKILL.md6.1 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Code Review Reception

Overview

Code review requires technical evaluation, not emotional performance.

Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.

The Response Pattern

WHEN receiving code review feedback:

1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each

Forbidden Responses

NEVER:

  • "You're absolutely right!" (explicit instruction-file violation)
  • "Great point!" / "Excellent feedback!" (performative)
  • "Let me implement that now" (before verification)

INSTEAD:

  • Restate the technical requirement
  • Ask clarifying questions
  • Push back with technical reasoning if wrong
  • Just start working (actions > words)

Handling Unclear Feedback

IF any item is unclear:
  STOP - do not implement anything yet
  ASK for clarification on unclear items

WHY: Items may be related. Partial understanding = wrong implementation.

Example:

your human partner: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.

❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."

Source-Specific Handling

From your human partner

  • Trusted - implement after understanding
  • Still ask if scope unclear
  • No performative agreement
  • Skip to action or technical acknowledgment

From External Reviewers

BEFORE implementing:
  1. Check: Technically correct for THIS codebase?
  2. Check: Breaks existing functionality?
  3. Check: Reason for current implementation?
  4. Check: Works on all platforms/versions?
  5. Check: Does reviewer understand full context?

IF suggestion seems wrong:
  Push back with technical reasoning

IF can't easily verify:
  Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"

IF conflicts with your human partner's prior decisions:
  Stop and discuss with your human partner first

your human partner's rule: "External feedback - be skeptical, but check carefully"

YAGNI Check for "Professional" Features

IF reviewer suggests "implementing properly":
  grep codebase for actual usage

  IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
  IF used: Then implement properly

your human partner's rule: "You and reviewer both report to me. If we don't need this feature, don't add it."

Implementation Order

FOR multi-item feedback:
  1. Clarify anything unclear FIRST
  2. Then implement in this order:
     - Blocking issues (breaks, security)
     - Simple fixes (typos, imports)
     - Complex fixes (refactoring, logic)
  3. Test each fix individually
  4. Verify no regressions

When To Push Back

Push back when:

  • Suggestion breaks existing functionality
  • Reviewer lacks full context
  • Violates YAGNI (unused feature)
  • Technically incorrect for this stack
  • Legacy/compatibility reasons exist
  • Conflicts with your human partner's architectural decisions

How to push back:

  • Use technical reasoning, not defensiveness
  • Ask specific questions
  • Reference working tests/code
  • Involve your human partner if architectural

If you're uncomfortable pushing back out loud: Name that tension, then tell your partner about the issue you've seen. They'll appreciate your honesty.

Acknowledging Correct Feedback

When feedback IS correct:

✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]

❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ ANY gratitude expression

Why no thanks: Actions speak. Just fix it. The code itself shows you heard the feedback.

If you catch yourself about to write "Thanks": DELETE IT. State the fix instead.

Gracefully Correcting Your Pushback

If you pushed back and were wrong:

✅ "You were right - I checked [X] and it does [Y]. Implementing now."
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."

❌ Long apology
❌ Defending why you pushed back
❌ Over-explaining

State the correction factually and move on.

Common Mistakes

MistakeFix
Performative agreementState requirement or just act
Blind implementationVerify against codebase first
Batch without testingOne at a time, test each
Assuming reviewer is rightCheck if breaks things
Avoiding pushbackTechnical correctness > comfort
Partial implementationClarify all items first
Can't verify, proceed anywayState limitation, ask for direction

Real Examples

Performative Agreement (Bad):

Reviewer: "Remove legacy code"
❌ "You're absolutely right! Let me remove that..."

Technical Verification (Good):

Reviewer: "Remove legacy code"
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"

YAGNI (Good):

Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"

Unclear Item (Good):

your human partner: "Fix items 1-6"
You understand 1,2,3,6. Unclear on 4,5.
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."

GitHub Thread Replies

When replying to inline review comments on GitHub, reply in the comment thread (gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies), not as a top-level PR comment.

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Turn development ideas into clear designs through guided discussion. The skill clarifies goals, requirements, and constraints, then adapts the process to a feasibility investigation, a small existing-code change, or a larger architectural design.

中文简介正在准备中。当前显示英语简介。

  • Clarifying requirements before adding a feature
  • Exploring whether an idea is feasible
  • Comparing designs for a new project
spacering-net/codeg40422026年10月20日 更新

Find academic papers, retrieve publication details, and build BibTeX reference files for scholarly writing. Check identifiers, missing information, duplicate entries, and mismatches between manuscript citations and the bibliography, with tools for formatting and validation.

中文简介正在准备中。当前显示英语简介。

  • Finding papers for a manuscript or thesis
  • Converting paper identifiers into BibTeX entries
  • Cleaning duplicate or incomplete references
spacering-net/codeg40422026年10月20日 更新

Assign independent bugs or test failures to separate agents that work at the same time. Define each agent’s scope and expected report, then check for conflicting changes and run the full test suite before integrating fixes.

中文简介正在准备中。当前显示英语简介。

  • Investigating test failures with unrelated causes
  • Fixing independent problems in separate subsystems
  • Defining focused tasks for multiple agents
spacering-net/codeg40422026年10月20日 更新

Carry out a written implementation plan in a separate session, reviewing it before starting and tracking each task through verification. The workflow pauses for blockers and hands completed work to a development branch finishing process.

中文简介正在准备中。当前显示英语简介。

  • Executing a written implementation plan
  • Tracking task progress and verification
  • Reviewing gaps before implementation
spacering-net/codeg40422026年10月20日 更新

Plan experiments before collecting data by choosing how to assign samples, combine conditions, and order runs. Generate reproducible allocation schedules and experimental layouts while checking for design flaws that could make results difficult to interpret.

中文简介正在准备中。当前显示英语简介。

  • Assigning subjects or samples to comparison groups
  • Screening many factors to identify promising ones
  • Planning around batch, day, or plate-position differences
spacering-net/codeg40422026年10月20日 更新

Explore scientific data files to understand their structure, statistical patterns, and quality. References cover over 200 formats, with workflows for producing Markdown reports that summarize findings and recommend preprocessing, visualizations, and further analysis.

中文简介正在准备中。当前显示英语简介。

  • Checking missing values and outliers in experimental tables
  • Examining sequence lengths and quality scores in FASTQ files
  • Inspecting microscopy image dimensions and metadata
spacering-net/codeg40422026年10月20日 更新

查看 spacering-net 的全部技能

报告此技能的问题