跳到正文
cccskills
免费在 GitHub 公开

review

Review code changes against project architecture, style, and conventions

中文简介正在准备中。当前显示原文说明。

查看安装方法

包含的文件(1)

  • SKILL.md2.3 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Review Changes

Review the current changes against the project's conventions and architecture rules.

Load the appropriate docs based on which code area is being reviewed:

  • Store code: @docs/store-compose.md, @docs/store-viewmodel-patterns.md, @docs/store-tracking-events.md, @docs/store-testing.md
  • POS code: @docs/pos-architecture.md, @docs/pos-tracking-events.md, @docs/pos-testing.md
  • Shared: @docs/coding-style.md

Steps

  1. Determine the diff to review. First check git diff trunk...HEAD for branch changes (most common: pre-PR review). If empty, fall back to git diff --cached for staged changes, then git diff for unstaged changes.

  2. Determine if the code is POS or store. POS: ui/woopos/, WooPos* prefix. Everything else: store management. Read the relevant docs above.

  3. Read the changed files in full to understand context, not just the diff hunks.

  4. Check against each category below. Only report actual issues found — do not report categories with no issues.

Architecture

  • POS: ViewModels extend ViewModel(), use parent-child SharedFlow event bus, pure Compose, Compose Navigation
  • Store: ViewModels extend ScopedViewModel, use triggerEvent() / MultiLiveEvent, Compose inside Fragments, XML nav graphs
  • Both: @HiltViewModel + @Inject constructor, data flows through repositories, ViewModels never access Room/network directly

Kotlin Style

  • Max 120 character line length (test names excepted)
  • No wildcard imports, no FIXME (use TODO), no !! force unwraps
  • Constants: UPPER_SNAKE_CASE, companion objects at bottom

Jetpack Compose

  • Check against patterns in docs/store-compose.md (store) or docs/pos-architecture.md (POS)

Testing

  • Store: BaseUnitTest, testBlocking, captureValues, AssertJ
  • POS: WooPosCoroutineTestRule, runTest, advanceUntilIdle, AssertJ

Analytics

  • Store: AnalyticsEvent enum, AnalyticsTrackerWrapper
  • POS: WooPosAnalyticsEvent sealed class, WooPosAnalyticsTracker

Output Format

## Blockers
- [file:line] Description of blocking issue

## Suggestions
- [file:line] Description of improvement suggestion

## Positives
- Description of what was done well

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Repair a failing WooCommerce Android Maestro flow by reproducing it against the store it runs on, inspecting Maestro selectors, patching the smallest selector/wait/setup issue, and rerunning with repeat evidence. Human-triggered only.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

pos

免费

POS (Point of Sale) architecture and patterns. Use when writing, editing, exploring, debugging, fixing bugs, implementing features, or reviewing WooPos-prefixed classes or files under ui/woopos/. POS uses a different architecture than the main app — plain ViewModel (not ScopedViewModel), pure Compose (no Fragments), Compose Navigation (no nav graphs), parent-child SharedFlow event bus. Loading this skill prevents applying main-app patterns that would be wrong for POS. For analytics use `pos-analytics`, for tests use `pos-tests`.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

POS analytics tracking patterns (WooPosAnalyticsEvent sealed class, WooPosAnalyticsTracker, WooPosAnalyticsEventConstant). Use when writing, editing, exploring, debugging, or reviewing analytics tracking in POS (WooPos*) code. NOT for main store app — use the `store-analytics` skill instead.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

pos-tests

免费

POS unit testing patterns (WooPosCoroutineTestRule, runTest, advanceUntilIdle, mockito-kotlin, event bus mocking, analytics verification). Use when writing, editing, exploring, debugging, or reviewing unit tests for POS (WooPos*) code. NOT for main store app tests — use the `store-tests` skill instead.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

pr

免费

Create a pull request following project conventions. Triggers on any request to create, open, make, submit, file, send, push, spin up, put up, draft, raise, or prepare a PR/pull request.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

Address PR reviewer feedback by evaluating comments, proposing fixes, and executing after user approval. Use when the user wants to handle review comments on an existing PR, address PR feedback, fix PR comments, respond to reviewer suggestions, or process code review feedback. Triggers on "address PR feedback", "handle review comments", "fix PR comments", "respond to PR review", "process reviewer feedback", or when given a PR number/URL with intent to address its comments.

中文简介正在准备中。当前显示原文说明。

woocommerce/woocommerce-android3192026年10月17日 更新

查看 woocommerce 的全部技能

报告此技能的问题