Skip to content
cccskills
FreePublished on GitHub

edge-strategy-reviewer

Review trading strategy drafts against eight criteria, including the rationale for an advantage, overfitting to past data, sample size, and realistic execution. Produce a scored verdict, revision instructions, and eligibility for export to the next pipeline stage.

OriginalShow the original description

Critically review strategy drafts from edge-strategy-designer for edge plausibility, overfitting risk, sample size adequacy, and execution realism. Use when strategy_drafts/*.yaml exists and needs quality gate before pipeline export. Outputs PASS/REVISE/REJECT verdicts with confidence scores.

Run score Not tested

See how to install

Good for

  • Review generated trading strategy drafts
  • Check for overfitting and too few trade examples
  • Identify revisions needed before export
  • Review research bias checklist coverage

Files included (8)

  • SKILL.md3.9 KB
  • assets/bias_checklist.yaml2.4 KB
  • references/overfitting_checklist.md2.0 KB
  • references/review_criteria.md4.3 KB
  • requirements.txt123 B
  • scripts/review_strategy_drafts.py31.0 KB
  • scripts/tests/conftest.py13.1 KB
  • scripts/tests/test_review_strategy_drafts.py31.5 KB

SKILL.md (original)

Review the instructions the agent will receive before you install.

Edge Strategy Reviewer

Deterministic quality gate for strategy drafts produced by edge-strategy-designer.

When to Use

  • After edge-strategy-designer generates strategy_drafts/*.yaml
  • Before exporting drafts to edge-candidate-agent via the pipeline
  • When manually validating a draft strategy for edge plausibility

Prerequisites

  • Strategy draft YAML files (output of edge-strategy-designer)
  • Python 3.10+ with PyYAML

Workflow

  1. Load draft YAML files from --drafts-dir or a single --draft file
  2. Evaluate each draft against 8 criteria (C1-C8) with weighted scoring
  3. Compute confidence score (weighted average of all criteria)
  4. Determine verdict: PASS / REVISE / REJECT
  5. Assess export eligibility (PASS + export_ready_v1 + exportable family)
  6. Write review output (YAML or JSON) and optional markdown summary

Review Criteria

#CriterionWeightKey Checks
C1Edge Plausibility20Thesis quality, domain terms, mechanism keywords (continuous 50-95)
C2Overfitting Risk205-tier filter count scoring (90/80/60/40/10), precise threshold penalty
C3Sample Adequacy15Continuous scoring from estimated annual opportunities (10-95)
C4Regime Dependency10Cross-regime validation
C5Exit Calibration10Stop-loss, reward-to-risk
C6Risk Concentration10Position sizing limits
C7Execution Realism10Volume filter, export consistency
C8Invalidation Quality5Signal count and specificity

Verdict Logic

  • C1 or C2 severity=fail → immediate REJECT
  • confidence >= 70, no fail findings → PASS
  • confidence < 35 → REJECT
  • Otherwise → REVISE (with revision instructions)

Running the Script

# Review all drafts in a directory
python3 skills/edge-strategy-reviewer/scripts/review_strategy_drafts.py \
  --drafts-dir reports/edge_strategy_drafts/ \
  --output-dir reports/

# Single draft review
python3 skills/edge-strategy-reviewer/scripts/review_strategy_drafts.py \
  --draft reports/edge_strategy_drafts/draft_xxx.yaml \
  --output-dir reports/

# JSON output with markdown summary
python3 skills/edge-strategy-reviewer/scripts/review_strategy_drafts.py \
  --drafts-dir reports/edge_strategy_drafts/ \
  --output-dir reports/ \
  --format json \
  --markdown-summary

# Strict export mode: export-eligible drafts with any warn → REVISE
python3 skills/edge-strategy-reviewer/scripts/review_strategy_drafts.py \
  --drafts-dir reports/edge_strategy_drafts/ \
  --output-dir reports/ \
  --strict-export

# Bias checklist (issue #297): mandatory strategy-research bias gate.
# Uses the bundled checklist unless a custom YAML path is supplied.
# A draft leaving any required item unaddressed is downgraded PASS → REVISE
# and loses export eligibility.
python3 skills/edge-strategy-reviewer/scripts/review_strategy_drafts.py \
  --drafts-dir reports/edge_strategy_drafts/ \
  --output-dir reports/ \
  --bias-checklist

Output Format

Primary output: review.yaml (or review.json)

generated_at_utc: "2026-02-28T12:00:00+00:00"
source:
  drafts_dir: "/path/to/strategy_drafts"
  draft_count: 4
summary:
  total: 4
  PASS: 1
  REVISE: 2
  REJECT: 1
  export_eligible: 1
reviews:
  - draft_id: "draft_xxx_core"
    verdict: "PASS"
    confidence_score: 80
    export_eligible: true
    findings: [...]
    revision_instructions: []

Resources

  • references/review_criteria.md — Detailed scoring rubric for C1-C8
  • references/overfitting_checklist.md — Overfitting detection heuristics

Reviews

No reviews yet. Tell others what you thought.

Comments

No login needed. Share how it worked for you, ask a question, or note where it did not run.

No comments yet. Be the first to write one.

Comments are published right away. Do not include personal information such as email addresses or phone numbers. Up to 2 URLs.

0 / 1,000 characters

This form is protected by reCAPTCHA, and the Google Privacy Policy and Terms of Service apply.

More skills from this repository

backtest-expert

FreeSummary

Plan and assess backtests, which test trading rules against historical data. Examine sensitivity to rule changes, trading costs, and data bias, then use supplied performance metrics to generate a structured evaluation with reasons that block adoption.

  • Define a backtesting plan for rule-based trading
  • Test sensitivity to parameters and trading costs
  • Investigate suspiciously strong backtest results
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

Assess how broadly US stock market gains are shared across stocks using public CSV data and optional charts. Produce English reports covering market conditions, trading signals, scenarios, and positioning for different investment timeframes.

  • Checking how broadly US stocks are participating in a market rise
  • Reviewing medium- to long-term market positioning
  • Assessing short-term swing trading signals
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

Analyze chart images showing how broadly US stocks are participating in market trends. Assess medium-term conditions and short-term signals, then produce an English report with positioning guidance, alternative scenarios, and risks based on the visible data.

  • Assessing the market cycle from an S&P 500 breadth chart
  • Checking short-term signals in an uptrend stock ratio chart
  • Comparing medium-term and short-term market signals
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

Turn VCP screening results, which identify narrowing price swings, into breakout trade plans. Calculate entry, stop-loss, target prices, and position sizes using worst-case entries, while applying portfolio risk limits and producing Alpaca-compatible order templates.

  • Planning entries, stop-losses, and profit targets for VCP candidates
  • Calculating position sizes from account size and risk limits
  • Checking total portfolio risk and sector exposure
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

canslim-screener

FreeSummary

Screen US growth stocks with William O'Neil's CANSLIM method, which evaluates seven factors including earnings, price strength, trading volume, and market direction. Receive ranked candidates with composite scores, factor breakdowns, market warnings, and data quality notes.

  • Find US stocks with earnings growth and price momentum
  • Compare a chosen list of stocks using CANSLIM scores
  • Screen a sector-focused stock list
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

Combine three reports on crowded positions, failed reactions to news, and weekly price reversals into one trading setup status. Identify missing or invalid evidence and determine whether the setup is ready for planning.

  • Combine three contrarian strategy reports
  • Check which confirmations are still missing
  • Find stale or inconsistent input reports
tradermonty/claude-trading-skills3.2KUpdated Oct 21, 2026

See all skills by tradermonty

Report a problem with this skill