跳到正文
cccskills
免费在 GitHub 公开

quality-review

Architectural and quality code review: standards compliance, SOLID principles, testability, performance. Usar para revisar un archivo o directorio antes de mergear, o cuando se pide code review. Para bugs de correctness está el /code-review nativo de Claude Code; este revisa diseño y estándares.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane星标 3(GitHub 3 + cccskills 0)

实测评分 未实测

查看安装方法

包含的文件(1)

  • SKILL.md4.6 KB

SKILL.md(原文)

安装前可以查看交给 AI 代理的指令内容。

Phase 1: Load Target Files

Read target file(s) in full. Read CLAUDE.md for project coding standards.

Phase 2: Resolve which specialists exist

Do not invent specialist names. List what is actually installed:

!ls .claude/agents/*/ 2>/dev/null | sed 's/\.md$//' | tr '\n' ' ' || echo "NO-AGENTS-INSTALLED"

Rules:

  • Only spawn an agent whose file appeared in that listing. A Task call naming an agent that is not installed does not fail loudly - it falls back to a general-purpose agent with no specialised prompt, which reads broadly, burns its turn budget, and returns a generic summary. That is worse than not spawning at all.
  • If the listing is empty or NO-AGENTS-INSTALLED, skip Phase 7 entirely and do the whole review inline. Say so in the report.
  • Match by role, not by guess: a reviewer for the stack under review (react-engineer, go-engineer, nestjs-engineer, unity-specialist, unreal-specialist…), plus qa-engineer for testability when installed.

Phase 3: ADR Compliance Check

Search for ADR-NNN patterns in story file, commits, headers. No references → skip.

Per referenced ADR, read Decision + Consequences sections, classify deviations:

SeverityMeaning
ARCHITECTURAL VIOLATION (BLOCKING)Uses pattern explicitly rejected in ADR
ADR DRIFT (WARNING)Meaningfully diverges from chosen approach
MINOR DEVIATION (INFO)Small difference, doesn't affect architecture

Phase 4: Standards Compliance

Identify system category from the code under review. Check: doc comments on public methods, cyclomatic complexity <10/method, methods ≤40 lines, DI (no static singletons), config from data files, interfaces exposed.

Phase 5: Architecture and SOLID

  • Architecture: correct dependency direction, no circular deps, proper layer separation, events for cross-system communication, consistent patterns
  • SOLID: SRP, OCP, LSP, ISP, DIP — check each principle

Phase 6: Runtime-loop concerns — only for game/realtime projects

Skip this phase unless the project actually has a frame loop. Signal: a Unity, Unreal or Godot project file, or a render/tick loop in the code under review. On a backend or web project this phase produces noise, not findings.

When it applies: frame-rate independence (delta time), no allocations in hot paths, null/empty handling, thread safety, resource cleanup.

Phase 7: Specialist Reviews (Parallel)

Only if Phase 2 found installed agents. At most 3 in parallel — beyond that the wall-clock cost outweighs the extra coverage.

Trigger in the diffSpawn (only if installed)
Primary language of the changed filesthe matching *-engineer / *-specialist
Shader / material filesunity-shader-specialist or technical-artist
UI / component codeui-lead or ue-umg-specialist
Test or testability questionsqa-engineer

Give each one the file list and the specific question. Do not ask an agent to "review this" — ask what you actually need decided.

Testability review

When qa-engineer is installed, ask it: are test hooks exposed, do test cases map to code paths, are acceptance criteria testable, are new edge cases and side effects covered. For visual/UI changes: are the manual steps reachable.

Phase 8: Output Review

Report sections: Specialist Findings (name which agents ran, and say plainly if none were installed), Testability, ADR Compliance, Standards Compliance (X/6), Architecture, SOLID, Runtime-loop Concerns (omit if skipped), Positive Observations, Required Changes (violations always here), Suggestions.

Verdict: APPROVED / APPROVED WITH SUGGESTIONS / CHANGES REQUIRED.

This skill is read-only: it writes no files. The report is the deliverable.

Phase 9: Next Steps

Skills below that ship with other profiles may not be installed: check .claude/skills/<name>/ first, and if it is missing offer /arcane-add <name> instead of running it.

  • APPROVED → /story-done [story-path]
  • CHANGES REQUIRED → fix issues, re-run /quality-review
  • ARCHITECTURAL VIOLATION → /architecture-decision to record correct approach

评价

还没有评价。欢迎分享你的使用感受。

评论

无需登录即可发表。欢迎分享使用感受、提问,或说明在哪些环境下无法运行。

还没有评论。来写第一条吧。

提交后会立即公开。请勿填写邮箱、电话等个人信息。URL 最多 2 个。

0 / 1000 字

此表单受 reCAPTCHA 保护,适用 Google 的隐私权政策和服务条款。

同一仓库的技能

Plan, design, and implement A/B tests and experiments with statistical rigor. Covers hypothesis frameworks, sample sizing, metrics, and result analysis.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

Web/mobile accessibility decision guide: WCAG 2.2 AA, ARIA, keyboard nav, focus management, contrast, testing. Use for: a11y, accessibility, wcag, aria, screen reader, keyboard, contrast.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

Generate, iterate, and scale ad creative for paid advertising across Google, Meta, LinkedIn, and X. Covers platform specs, creative frameworks, and quality validation.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

Musica interactiva para juegos: layering vertical, re-secuenciacion horizontal, stingers, reglas de transicion con sync points, y mapeo de estados de gameplay a musica. Usar para: musica adaptativa, sistema de musica dinamica, transiciones musicales, combat music.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

Design multi-agent systems, create agent architectures, define communication patterns, and build autonomous agent workflows with structured evaluation frameworks.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

Inter-agent communication protocol for C-suite agent teams. Defines invocation syntax, loop prevention, isolation rules, response formats, and quality loops.

中文简介正在准备中。当前显示原文说明。

SebastianLuser/claude-code-arcane32026年10月27日 更新

查看 SebastianLuser 的全部技能

报告此技能的问题